Skip to content

Commit 216d732

Browse files
authored
Merge pull request #6555 from akatsoulas/500-delete-user-with-reply
Fix error on user deletion with reply
2 parents 2d75e42 + f7705aa commit 216d732

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

kitsune/questions/models.py

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -704,20 +704,15 @@ def is_taken(self):
704704
"""
705705
Convenience method to check that a question is taken.
706706
707-
Additionally, if ``self.taken_until`` is in the past, this will reset
708-
the database fields to expire the setting.
707+
If the question is no longer validly taken (due to missing user or expired time),
708+
this will reset the database fields and return False.
709709
"""
710-
if self.taken_by is None:
711-
assert self.taken_until is None
712-
return False
710+
if self.taken_by is None or self.taken_until is None or self.taken_until < datetime.now():
713711

714-
assert self.taken_until is not None
715-
if self.taken_until < datetime.now():
716712
self.taken_by = None
717713
self.taken_until = None
718714
self.save()
719715
return False
720-
721716
return True
722717

723718
def take(self, user, force=False):

0 commit comments

Comments
 (0)